🎨 Enhances Iicence feature: new vendor phantoms and licensed-resource-data id (🚨)
#7179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcrespov
added
a:webserver
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7179 +/- ##
==========================================
- Coverage 87.66% 87.24% -0.43%
==========================================
Files 1641 1634 -7
Lines 64171 63998 -173
Branches 1179 1179
==========================================
- Hits 56255 55832 -423
- Misses 7605 7855 +250
Partials 311 311
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
odeimaiz
reviewed
Feb 6, 2025
packages/models-library/src/models_library/api_schemas_webserver/licensed_items.py
Show resolved
Hide resolved
pcrespov
changed the title
idid
pcrespov
changed the title
idid (🚨)
pcrespov
force-pushed
the
is1732/add-phantoms-speag-vendor
branch
from
374a255 to
92046e7
Compare
pcrespov
requested review from
GitHK,
YuryHrytsuk,
giancarloromeo,
matusdrobuliak66,
mrnicegyu11 and
sanderegg
as code owners
mguidon
approved these changes
Feb 6, 2025
Member
mguidon
left a comment
mguidon
left a comment
There was a problem hiding this comment.
Gracias. Ping me when this goes live
GitHK
approved these changes
Feb 6, 2025
giancarloromeo
approved these changes
Feb 6, 2025
|
YuryHrytsuk
approved these changes
Feb 6, 2025
matusdrobuliak66
approved these changes
Feb 6, 2025
mrnicegyu11
pushed a commit
to mrnicegyu11/osparc-simcore
that referenced
this pull request
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Enhancements of the licenses feature:
idneeded by the front-end (requested by @odeimaiz )Related issue/s
How to test
Manually tested in local deploy setting
.envwith envs in osparc-config MRComputationalPhantomsweb-api
GET v0/catalog/licensed-itemsresponds with{ # ... "data": [ { "licensedItemId": "5a66b856-b116-4309-a2f9-d3224f818326", "displayName": "SHO-RC-V1 V1.0", "licensedResourceType": "VIP_MODEL", "licensedResourceData": { "categoryId": "ComputationalPhantom", "categoryDisplay": "Phantom of the Opera", "source": { "id": 78, "description": "SPEAG Posable Hand Phantom for Clamshell Phones - Right", "thumbnail": "https://speag.swiss/assets/images/Sim4Life/semshorc.png", "features": { "name": "SHO-RC-V1", "version": "V1.0", "date": "2024-11-05", "functionality": "Posable" }, "doi": null }, "termsOfUseUrl": null }, "pricingPlanId": 1, "createdAt": "2025-02-06T12:38:54.079488Z", "modifiedAt": "2025-02-06T12:38:54.079488Z" } ] }public-api
GET /licensed-itemsproduces{ "items": [ { "licensed_item_id": "5a66b856-b116-4309-a2f9-d3224f818326", "display_name": "SHO-RC-V1 V1.0", "licensed_resource_type": "VIP_MODEL", "licensed_resource_data": { "source": { "id": 78, "doi": null, "features": { "date": "2024-11-05", "name": "SHO-RC-V1", "version": "V1.0", "functionality": "Posable" }, "thumbnail": "https://speag.swiss/assets/images/Sim4Life/semshorc.png", "protection": "Code", "description": "SPEAG Posable Hand Phantom for Clamshell Phones - Right", "license_key": "MODEL_SEMSHO_RC", "license_version": "V1.0", "available_from_url": null }, "category_id": "ComputationalPhantom", "category_display": "Phantom of the Opera" }, "pricing_plan_id": 1, "created_at": "2025-02-06T12:38:54.079488Z", "modified_at": "2025-02-06T12:38:54.079488Z" } ], "total": 1, "limit": 20, "offset": 0, "links": { "first": "/v0/licensed-items?limit=20&offset=0", "last": "/v0/licensed-items?limit=20&offset=0", "self": "/v0/licensed-items?limit=20&offset=0", "next": null, "prev": null } }Dev-ops